fix: handle flat alternating header arrays in cache normalizeHeaders#5536
Open
mcollina wants to merge 3 commits into
Open
fix: handle flat alternating header arrays in cache normalizeHeaders#5536mcollina wants to merge 3 commits into
mcollina wants to merge 3 commits into
Conversation
The cache interceptor's normalizeHeaders function only handled two header
formats: array-of-pairs ([[key, val], ...]) and plain objects ({ key: val, ...}).
However, undici internally uses flat alternating arrays ([key, val, key, val, ...]).
When the cache() interceptor is placed before dns() in a compose chain, the DNS
interceptor converts headers to flat alternating format before passing them to
the cache interceptor, causing normalizeHeaders to throw
'opts.headers is not a valid header map'.
Fixes #5522
ronag
approved these changes
Jul 9, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5536 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 110 110
Lines 37328 37418 +90
=======================================
+ Hits 34881 34966 +85
- Misses 2447 2452 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The cache interceptor's
normalizeHeadersfunction only handled two headerformats:
[['key', 'val'], ...]{ key: 'val', ... }However, undici internally uses flat alternating arrays:
['key', 'val', 'key', 'val', ...]. When thecache()interceptor is placedbefore
dns()in a compose chain (e.g.,new Agent().compose(cache(), dns())),the DNS interceptor converts headers to flat format before passing them to
the cache interceptor, causing
normalizeHeadersto throw'opts.headers is not a valid header map'.Reproduction
Fixes #5522